Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voice debug link #23214

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Fix voice debug link #23214

merged 1 commit into from
Dec 8, 2024

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 8, 2024

Breaking change

Proposed change

Handle navigation with a JavaScript event handler instead of a tag. We're preventing click propagation because we have a menu inside a whole row clickable list-item.

Fixes #22962

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added this to the 2024.12 milestone Dec 8, 2024
@piitaya piitaya merged commit 8390c6e into dev Dec 8, 2024
16 checks passed
@piitaya piitaya deleted the fix-voice-debug branch December 8, 2024 21:32
bramkragten pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of Assistants config page
3 participants