Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom TimeLineScale for chartjs #23270

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

MindFreeze
Copy link
Contributor

Proposed change

This custom doesn't seem to do more than the one in chartjs but it breaks the zoom out proposed in #23183
In my testing I saw no other difference between this timeline scale and the normal time scale.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze mentioned this pull request Dec 12, 2024
9 tasks
@bramkragten bramkragten merged commit f0ddc40 into dev Dec 12, 2024
16 checks passed
@bramkragten bramkragten deleted the remove_custom_timescale branch December 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants