Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow user to choose cloud if ha settings is not set #23364

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 20, 2024

Proposed change

Don't allow user to choose cloud if ha settings is not set
I also removed the agent option from upload dialog as discussed with @matthiasdebaat.

CleanShot 2024-12-20 at 16 21 46

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:


@property({ attribute: false })
public value!: string[];

private _agentIds = memoizeOne((agents: BackupAgent[]) =>
agents.map((agent) => agent.agent_id).sort(compareAgents)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove the sorting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was moved ok...

@piitaya piitaya merged commit dc799bf into dev Dec 20, 2024
16 checks passed
@piitaya piitaya deleted the backup_cloud_no_ha branch December 20, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants