-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Abode docs to point to jaraco.abode library #32722
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -81,8 +81,8 @@ All {% term events %} have the fields: | |||
| `date` | The date of the event in the format `MM/DD/YYYY`. | | |||
| `time` | The time of the event in the format `HH:MM AM`. | | |||
|
|||
There is a unique list of known event_codes that can be found | |||
[here](https://github.com/MisterWil/abodepy/files/1262019/timeline_events.txt). | |||
There is a unique list of known event_codes are defined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the link to abodepy removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had checked the URL and thought it was 404. Turns out it wasn't 404, but when I first browsed to the URL, I included the trailing )
, which was 404, then when I corrected it and removed the trailing )
, Firefox quietly downloaded the file and left me on the 404 page (leading me to believe the URL itself was 404).
So I sought to find a suitable replacement in the jaraco.abode
project, which supersedes the abodepy project. Now that I see the contents of timeline_events.txt, I see there is a bit of extra information in that text file, information which is lost outside of the previous project's GitHub repo. I'll restore that content in the project itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha. I see now that the "groups" is codified as well, so I'll update the docs to link to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in cf6e9d6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jaraco 👍
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.