Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs of Markdown card to reflect show_empty functionality #33720

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

illuzn
Copy link
Contributor

@illuzn illuzn commented Jul 12, 2024

Proposed change

This documents the implementation of show_empty: true/ false functionality for the markdown card. The functionality is similar to the entity filter card.

This resolves a requested feature here (https://www.reddit.com/r/homeassistant/comments/y2nwz0/hide_markdown_card_if_empty/) for which there are no appropriate solutions.

It is possible using templates to create conditions which far exceed the capability of the conditional card or the "visibility" settings of cards so this functionality is required. For example, you currently cannot toggle visibility based on an attribute of a card currently.

The workaround suggested in that reddit thread (using a template sensor and outputting to state) isn't appropriate because the text output from a markdown card can exceed the maximum of 255 characters.

There is no existing translation in the entity filter card for "show_empty" so the visual editor couldn't be implmented in this case.

By default, the existing behaviour is kept i.e. an empty card is shown which results in a small empty box.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Added a configuration option show_empty to control the visibility of empty cards in dashboards. By default, empty cards are displayed (true), but this can be set to false to hide them.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Jul 12, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

Copy link
Contributor

coderabbitai bot commented Jul 12, 2024

Walkthrough

Walkthrough

A new configuration option show_empty has been added to the markdown.markdown file. This option controls whether an empty card is displayed or hidden, with the default setting being true. This enhancement provides greater flexibility in managing the visibility of UI components based on their content presence.

Changes

File Path Change Summary
source/_dashboards/markdown.markdown Added a new configuration option show_empty to control the display of empty cards.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Dashboard
    participant Config

    User->>Dashboard: Initialize dashboard
    Dashboard->>Config: Read show_empty setting
    alt show_empty is true
        Dashboard-->>User: Display empty card
    else show_empty is false
        Dashboard-->>User: Hide empty card
    end
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 10ace16
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6698d59b8ea1400008ec7546
😎 Deploy Preview https://deploy-preview-33720--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 12, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)
source/_dashboards/markdown.markdown (1)

58-59: Improve the description clarity.

The description should be clearer and start with an uppercase letter. Consider rephrasing for better readability.

-  description: By default, an empty card will still be shown (resulting in a small empty box). Setting this to `true`, hides that empty card instead.
+  description: By default, an empty card will still be shown (resulting in a small empty box). Setting this to `true` hides the empty card instead.
Tools
LanguageTool

[typographical] ~59-~59: This sentence does not start with an uppercase letter.
Context: ...true`, hides that empty card instead. default: true type: string {% endconfiguratio...

(UPPERCASE_SENTENCE_START)

source/_dashboards/markdown.markdown Outdated Show resolved Hide resolved
@illuzn
Copy link
Contributor Author

illuzn commented Jul 12, 2024

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
source/_dashboards/markdown.markdown (1)

58-58: Correct the typographical error.

The description should start with an uppercase letter.

-  description: By default, an empty card will still be shown (resulting in a small empty box). Setting this to `false`, hides that empty card instead.
+  description: By default, an empty card will still be shown (resulting in a small empty box). Setting this to `false`, hides that empty card instead.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @illuzn 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Jul 18, 2024
@c0ffeeca7 c0ffeeca7 added the parent-merged The parent PR has been merged already label Jul 31, 2024
@c0ffeeca7 c0ffeeca7 merged commit 0a39742 into home-assistant:next Jul 31, 2024
6 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Jul 31, 2024
@illuzn illuzn deleted the markdown_show_empty_doc_update branch August 1, 2024 01:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants