Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity badge #33866

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Add entity badge #33866

merged 3 commits into from
Jul 19, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jul 18, 2024

Proposed change

Add new badge : the entity badge
I also replaced the screenshot at the top as this badge will be the default. Another PR will come to remove the state-label one as it will be replaced by this one.
I also fixed state_content description (last_changed and last_updated).

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the description for the state_content field to include more attribute options like last_updated, providing users with greater flexibility.
    • Added a new section detailing the configuration options for the "Entity Badge," explaining how to customize the display of entity states on badges.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jul 18, 2024
Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Walkthrough

Walkthrough

This update enhances the configuration documentation for dashboards by introducing detailed guidelines for the "Entity Badge" feature in badges.markdown. Users can now customize badge displays for entities more effectively. Additionally, the description of the state_content field in tile.markdown has been updated to include more options, such as last_updated, thereby increasing the flexibility in displaying state attributes.

Changes

File Change Summary
source/_dashboards/tile.markdown Updated the description for the state_content field to include additional options like last_updated.
source/dashboards/badges.markdown Introduced a new section for "Entity Badge" configuration, detailing various customization options including entity, name, icon, and actions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 5f97197
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/669a116c3e807c00084a5175
😎 Deploy Preview https://deploy-preview-33866--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (2)
source/_dashboards/tile.markdown (1)

64-64: Improve description for clarity.

The description can be improved by forming a complete sentence.

-    Content to display for the state. Can be `state`, `last_changed`, `last_updated`, or any attribute of the entity. Can be either a string with a single item, or a list of string items. Default depends on the entity domain.
+    The content to display for the state. It can be `state`, `last_changed`, `last_updated`, or any attribute of the entity. It can be either a string with a single item, or a list of string items. The default depends on the entity domain.
Tools
LanguageTool

[style] ~64-~64: To form a complete sentence, be sure to include a subject.
Context: ...> Content to display for the state. Can be state, last_changed, `last_updat...

(MISSING_IT_THERE)


[style] ~64-~64: To form a complete sentence, be sure to include a subject.
Context: ...dated`, or any attribute of the entity. Can be either a string with a single item, ...

(MISSING_IT_THERE)

source/dashboards/badges.markdown (1)

57-57: Improve description for clarity.

The description can be improved by forming a complete sentence.

-    Content to display for the state. Can be `state`, `last_changed`, `last_updated`, or any attribute of the entity. Can be either a string with a single item, or a list of string items. Default depends on the entity domain.
+    The content to display for the state. It can be `state`, `last_changed`, `last_updated`, or any attribute of the entity. It can be either a string with a single item, or a list of string items. The default depends on the entity domain.
Tools
LanguageTool

[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...> Content to display for the state. Can be state, last_changed, `last_updat...

(MISSING_IT_THERE)


[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...dated`, or any attribute of the entity. Can be either a string with a single item, ...

(MISSING_IT_THERE)

source/dashboards/badges.markdown Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (3)
source/dashboards/badges.markdown (3)

41-41: Consider adding the article "the".

The sentence might be missing the article "the" before "state".

- By default, the color is based on `state`, `domain`, and `device_class` of your entity.
+ By default, the color is based on the `state`, `domain`, and `device_class` of your entity.
Tools
LanguageTool

[uncategorized] ~41-~41: You might be missing the article “the” here.
Context: ...tive. By default, the color is based on state, domain, and device_class of ...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


57-57: Consider revising for clarity.

The sentence could be more clear by including a subject and determiner.

- Can be either a string with a single item, or a list of string items. Default depends on the entity domain.
+ It can be either a string with a single item, or a list of string items. The default depends on the entity domain.
Tools
LanguageTool

[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...> Content to display for the state. Can be state, last_changed, `last_updat...

(MISSING_IT_THERE)


[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...dated`, or any attribute of the entity. Can be either a string with a single item, ...

(MISSING_IT_THERE)


[uncategorized] ~57-~57: A determiner appears to be missing. Consider inserting it.
Context: ...single item, or a list of string items. Default depends on the entity domain. type: [...

(AI_EN_LECTOR_MISSING_DETERMINER)


55-58: Clarify the description of state_content.

The description could be more clear by including a subject and determiner.

- Content to display for the state. Can be `state`, `last_changed`, `last_updated`, or any attribute of the entity. Can be either a string with a single item, or a list of string items. Default depends on the entity domain.
+ The content to display for the state. It can be `state`, `last_changed`, `last_updated`, or any attribute of the entity. It can be either a string with a single item, or a list of string items. The default depends on the entity domain.
Tools
LanguageTool

[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...> Content to display for the state. Can be state, last_changed, `last_updat...

(MISSING_IT_THERE)


[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...dated`, or any attribute of the entity. Can be either a string with a single item, ...

(MISSING_IT_THERE)


[uncategorized] ~57-~57: A determiner appears to be missing. Consider inserting it.
Context: ...single item, or a list of string items. Default depends on the entity domain. type: [...

(AI_EN_LECTOR_MISSING_DETERMINER)

source/dashboards/badges.markdown Outdated Show resolved Hide resolved
source/dashboards/badges.markdown Outdated Show resolved Hide resolved
source/dashboards/badges.markdown Outdated Show resolved Hide resolved
source/dashboards/badges.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @piitaya 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Jul 19, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range, codebase verification and nitpick comments (4)
source/dashboards/badges.markdown (4)

22-23: Improve description for the type field.

The description "entity" is not clear. It should specify that the value must be entity.

- description: "`entity`"
+ description: "Must be `entity`"

31-34: Clarify description for the name field.

The description "Overwrites the entity name" could be clearer. Specify that it overwrites the displayed entity name.

- description: Overwrites the entity name.
+ description: Overwrites the displayed entity name.

Line range hint 109-111: Clarify description for the entities field.

The description "A list of entity IDs or entity objects, see below." could be clearer. Specify that it is a list of entity IDs or objects with an entity key.

- description: A list of entity IDs or `entity` objects, see below.
+ description: A list of entity IDs or objects with an `entity` key, see below.
Tools
LanguageTool

[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...> Content to display for the state. Can be state, last_changed, `last_updat...

(MISSING_IT_THERE)


[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...dated`, or any attribute of the entity. Can be either a string with a single item, ...

(MISSING_IT_THERE)


Line range hint 233-235: Clarify description for the state field.

The description "Entity state or ID to be equal to this value." could be clearer. Specify that it is the entity state or ID that must be equal to the specified value.

- description: Entity state or ID to be equal to this value.
+ description: The entity state or ID that must be equal to this value.
Tools
LanguageTool

[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...> Content to display for the state. Can be state, last_changed, `last_updat...

(MISSING_IT_THERE)


[style] ~57-~57: To form a complete sentence, be sure to include a subject.
Context: ...dated`, or any attribute of the entity. Can be either a string with a single item, ...

(MISSING_IT_THERE)

source/dashboards/badges.markdown Show resolved Hide resolved
source/dashboards/badges.markdown Show resolved Hide resolved
@frenck frenck merged commit 11aec70 into next Jul 19, 2024
8 checks passed
@frenck frenck deleted the entity_badge branch July 19, 2024 10:07
@home-assistant home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Jul 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants