-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate views: add screenshot #35604
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes involve updates to the documentation for dashboard views. The migration process for converting a view into a sections view has been clarified, specifically changing the instruction for handling imported cards from a passive selection to an interactive drag-and-drop method. Additionally, a new illustrative image has been added to aid in understanding this process. The section on view URLs remains unchanged, and existing examples for view and subview configuration are still intact. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashboard
participant Documentation
User->>Documentation: Access migration instructions
Documentation-->>User: Display updated instructions
User->>Dashboard: Drag cards into sections
Dashboard-->>User: Confirm cards are organized
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
source/dashboards/views.markdown (1)
90-90
: Consider enhancing the image accessibility.The screenshot addition is valuable for demonstrating the card migration process. However, consider making the alt text more descriptive for better accessibility.
- ![Move cards from imported cards section onto your dashboard](/images/dashboards/imported-cards.png) + ![Screenshot showing how to drag cards from the imported cards section to organize them into sections on your dashboard](/images/dashboards/imported-cards.png)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
source/images/dashboards/imported-cards.png
is excluded by!**/*.png
📒 Files selected for processing (1)
source/dashboards/views.markdown
(1 hunks)
🔇 Additional comments (1)
source/dashboards/views.markdown (1)
87-89
: LGTM! Clearer instruction for card migration.
The updated wording better describes the drag-and-drop interaction, making it more intuitive for users to understand how to organize their cards.
📝 WalkthroughWalkthroughThe changes in the documentation for dashboards primarily focus on updating the instructions for migrating views, specifically the method for moving cards. The documentation now includes a new image to aid understanding and clarifies how the URL for a view is constructed. Additionally, the visibility settings for views have been expanded to allow for more detailed configurations. Overall, these modifications aim to improve clarity and usability for users interacting with the dashboard views. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashboard
participant Documentation
User->>Documentation: Access view migration instructions
Documentation-->>User: Display updated instructions
User->>Dashboard: Drag cards into sections
Dashboard-->>User: Update sections with cards
User->>Documentation: Review visibility settings
Documentation-->>User: Provide detailed visibility configuration
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
source/dashboards/views.markdown (2)
90-90
: LGTM: Helpful screenshot addition.The new screenshot effectively illustrates the card migration process. The image path and alt text follow documentation standards.
Consider enhancing the alt text to be more descriptive, e.g., "Screenshot showing the imported cards section with draggable cards in the dashboard editor"
87-90
: Consider adding a Prerequisites section.The migration instructions would benefit from a "Prerequisites" subsection before step 1, clarifying what users need before starting the migration (e.g., existing view, edit permissions).
Example addition:
### Prerequisites - An existing view that you want to migrate - Administrator access or appropriate permissions to edit dashboards - Basic familiarity with the dashboard editor
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
source/images/dashboards/imported-cards.png
is excluded by!**/*.png
📒 Files selected for processing (1)
source/dashboards/views.markdown
(1 hunks)
🔇 Additional comments (1)
source/dashboards/views.markdown (1)
87-87
: LGTM: Improved clarity in migration instructions.
The change from "place them" to "drag them" better describes the actual user interaction, making the instructions more precise and actionable.
Thanks! |
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit