Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability explanation to template advanced #36910

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jan 13, 2025

Proposed change

Adds explanation to availability in template advanced configuration topic.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Added a new section on "Availability" in the templating documentation for Home Assistant.
    • Explained how availability templates affect entity rendering and state.
    • Included an example YAML configuration for defining availability templates for sensor entities.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jan 13, 2025
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit b1f373a
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/678a9e52a918b700074881bc
😎 Deploy Preview https://deploy-preview-36910--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 13, 2025

📝 Walkthrough

Walkthrough

The documentation update introduces a new section on "Availability" in the templating documentation for Home Assistant. This section explains how availability templates can be used to conditionally render state- and trigger-based templates. The documentation clarifies the criteria for determining an entity's availability, including specific truthy values that indicate availability and the implications of an entity being marked as unavailable.

Changes

File Change Summary
source/_docs/configuration/templating.markdown Added new "Availability" section explaining availability templates, their usage, and behavior in Home Assistant

Sequence Diagram

sequenceDiagram
    participant Template as Availability Template
    participant Entity as Home Assistant Entity
    
    Template->>Entity: Evaluate availability
    alt Availability Conditions Met
        Entity-->>Template: Entity Available
        Template->>Entity: Render Full Template
    else Availability Conditions Not Met
        Entity-->>Template: Entity Unavailable
        Template->>Entity: Suppress Attributes
    end
Loading

The sequence diagram illustrates the process of evaluating an entity's availability using an availability template, showing how the template determines whether the full entity information should be rendered or suppressed.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_docs/configuration/templating.markdown (3)

359-359: Fix hyphenation in "case sensitive".

The term should be hyphenated as "case-sensitive" when used as a compound adjective.

-Note that the string comparison not case sensitive; `"TrUe"` and `"yEs"` are allowed.
+Note that the string comparison is not case-sensitive; `"TrUe"` and `"yEs"` are allowed.
🧰 Tools
🪛 LanguageTool

[misspelling] ~359-~359: This word is normally spelled with a hyphen.
Context: ...e. Note that the string comparison not case sensitive; "TrUe"and"yEs"` are allowed. It ...

(EN_COMPOUNDS_CASE_SENSITIVE)


361-363: Fix possessive pronoun "it's".

Use "its" (possessive) instead of "it's" (contraction of "it is").

-At which point, it will again render the icon according to it's template.
+At which point, it will again render the icon according to its template.
🧰 Tools
🪛 LanguageTool

[grammar] ~363-~363: Did you mean the possessive pronoun “its”?
Context: ...will again render the icon according to it's template. #### Availability use exampl...

(IT_S_ITS)


365-379: Enhance the example with comments and realistic conditions.

While the example is functional, it could be more educational with inline comments and realistic availability conditions.

 template:
   - sensor:
       - name: "Transmission Up Speed"
         unit_of_measurement: "kB/s"
         state: "{{ states.sensor.test_sensor.state }}"
-        availability: "{{ is_state('sensor.test_sensor', 'on') }}"
+        # Only render templates if the test sensor is connected and reporting valid data
+        availability: >-
+          {{ 
+            is_state('sensor.test_sensor', 'on') and 
+            not is_state('sensor.test_sensor','unavailable') and 
+            not is_state('sensor.test_sensor','unknown')
+          }}
         icon: "{% if states.sensor.test_sensor.state == 'on' %}mdi:on{% else %}mdi:off{% endif %}"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5546985 and e4894e1.

📒 Files selected for processing (1)
  • source/_docs/configuration/templating.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_docs/configuration/templating.markdown

[misspelling] ~359-~359: This word is normally spelled with a hyphen.
Context: ...e. Note that the string comparison not case sensitive; "TrUe"and"yEs"` are allowed. It ...

(EN_COMPOUNDS_CASE_SENSITIVE)


[grammar] ~363-~363: Did you mean the possessive pronoun “its”?
Context: ...will again render the icon according to it's template. #### Availability use exampl...

(IT_S_ITS)

🔇 Additional comments (1)
source/_docs/configuration/templating.markdown (1)

355-358: LGTM! Clear and concise introduction.

The introduction effectively explains the purpose of availability templates and their role in suppressing template rendering.

source/_docs/configuration/templating.markdown Outdated Show resolved Hide resolved
source/_docs/configuration/templating.markdown Outdated Show resolved Hide resolved
source/_docs/configuration/templating.markdown Outdated Show resolved Hide resolved
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 17, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4894e1 and b1f373a.

📒 Files selected for processing (1)
  • source/_docs/configuration/templating.markdown (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_docs/configuration/templating.markdown (3)

361-363: 🛠️ Refactor suggestion

Improve clarity of implications explanation.

The explanation could be clearer about what happens when an entity becomes unavailable.

Apply this diff to improve clarity:

-For example, if the entity has the icon `mdi:on` and becomes unavailable, the icon will remain `mdi:on` until the entity becomes available. At that point, it will again render the icon according to its template.
+For example, if the entity has the icon `mdi:on` and becomes unavailable, the icon will remain `mdi:on` until the entity becomes available. At that point, it will again render the icon according to its template.

Likely invalid or redundant comment.


355-357: 🛠️ Refactor suggestion

Improve clarity of the introduction.

The current wording could be clearer about how availability templates affect template rendering.

Apply this diff to improve clarity:

-Both state- and trigger-based templates can have an availability template that suppresses further rendering of other templates if the availability renders as `False`.
+Both state- and trigger-based templates can have an availability template that suppresses further rendering of other templates if the availability renders as `False`.

Likely invalid or redundant comment.


359-360: 🛠️ Refactor suggestion

Improve clarity of availability behavior explanation.

The explanation could be clearer about valid values and case-insensitivity.

Apply this diff to improve clarity:

-If the template either fails to render or returns True, "1", "true", "yes", "on", "enable", or a non-zero number, the entity will be available. For any other value, the entity will be `unavailable`. Note that the string comparison is not case-sensitive; `"TrUe"` and `"yEs"` are allowed.
+If the template either fails to render or returns True, "1", "true", "yes", "on", "enable", or a non-zero number, the entity will be available. For any other value, the entity will be `unavailable`. Note that the string comparison is not case-sensitive; `"TrUe"` and `"yEs"` are allowed.

Likely invalid or redundant comment.

Comment on lines +365 to +379
#### Availability use example

{% raw %}

```yaml
template:
- sensor:
- name: "Transmission Up Speed"
unit_of_measurement: "kB/s"
state: "{{ states.sensor.test_sensor.state }}"
availability: "{{ is_state('sensor.test_sensor', 'on') }}"
icon: "{% if states.sensor.test_sensor.state == 'on' %}mdi:on{% else %}mdi:off{% endif %}"
```

{% endraw %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve the example to be more realistic and clear.

The current example has several issues:

  1. Uses a test sensor which may not be available.
  2. Uses an 'on' state which is not typical for sensors.
  3. Mixes availability and icon conditions which may be confusing.

Consider using this more realistic example:

 template:
   - sensor:
-      - name: "Transmission Up Speed"
-        unit_of_measurement: "kB/s"
-        state: "{{ states.sensor.test_sensor.state }}"
-        availability: "{{ is_state('sensor.test_sensor', 'on') }}"
-        icon: "{% if states.sensor.test_sensor.state == 'on' %}mdi:on{% else %}mdi:off{% endif %}"
+      - name: "Living Room Temperature"
+        unit_of_measurement: "°C"
+        state: "{{ states('sensor.living_room_temp_raw') }}"
+        availability: >
+          {{ not is_state('sensor.living_room_temp_raw', 'unavailable')
+             and not is_state('sensor.living_room_temp_raw', 'unknown') }}
+        icon: >
+          {% if states('sensor.living_room_temp_raw') | float > 25 %}
+            mdi:thermometer-high
+          {% else %}
+            mdi:thermometer-low
+          {% endif %}

This example:

  1. Uses a more realistic temperature sensor scenario
  2. Shows proper availability checking for sensor states
  3. Demonstrates a meaningful icon template based on temperature values
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#### Availability use example
{% raw %}
```yaml
template:
- sensor:
- name: "Transmission Up Speed"
unit_of_measurement: "kB/s"
state: "{{ states.sensor.test_sensor.state }}"
availability: "{{ is_state('sensor.test_sensor', 'on') }}"
icon: "{% if states.sensor.test_sensor.state == 'on' %}mdi:on{% else %}mdi:off{% endif %}"
```
{% endraw %}
#### Availability use example
{% raw %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants