Added the documentation for camera support of the tasmota integration. #36939
Conversation
home-assistant
bot
added
has-parent
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the Tasmota integration documentation for Home Assistant by enhancing the details regarding camera functionality. It specifies that the Changes
Sequence DiagramsequenceDiagram
participant Tasmota Device
participant Home Assistant Server
Note over Tasmota Device, Home Assistant Server: Must be on same local network
Tasmota Device->>Home Assistant Server: Camera Stream Available
Home Assistant Server->>Home Assistant Server: Create Camera Entity
Home Assistant Server-->>Tasmota Device: Camera Integration Established
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
source/_integrations/tasmota.markdown (1)
Line range hint
36-49: Documentation looks good overall!The camera support documentation is well-integrated with the existing content and provides clear requirements and limitations. Consider these future improvements:
- Add example configuration or setup steps specific to camera functionality
- Include troubleshooting tips for common camera setup issues
- Add information about supported camera resolutions or quality settings
🧰 Tools
🪛 GitHub Actions: home-assistant.io Test
[error] 36-36: Incorrect usage of the term: "home assistant", use "Home Assistant" instead
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/tasmota.markdown(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: home-assistant.io Test
source/_integrations/tasmota.markdown
[error] 36-36: Incorrect usage of the term: "home assistant", use "Home Assistant" instead
[error] 49-49: Incorrect usage of the term: "home assistant", use "Home Assistant" instead
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/tasmota.markdown (1)
40-40: LGTM!The addition of "Cameras" to the supported features list is well-formatted and maintains alphabetical ordering.
| @@ -45,6 +46,7 @@ Tasmota Buttons, Fans, Lights, Relays, Sensors, Shutters and Switches are suppor | |||
| - Tasmota Shutters will be added as Home Assistant `cover` entities. Currently only Shutter modes 1 to 4 are supported. Shutter mode 5 and Tuya shutters are not supported. | |||
| - Tasmota Switches will be added as either Home Assistant `binary_sensor` entities or `automation triggers` depending on the `switchmode` used when `SetOption114` is enabled. | |||
| - The fan functionality in Tasmota devices with module configured as `iFan02` or `iFan03` will be added as Home Assistant `fan` entities. Tuya fans are not supported. | |||
| - The camera functionality in ESP32 Tasmota devices with tasmota32-webcam firmware will be added as Home Assistant `Camera` entities. Note that this functionality is supported only when the Tasmota device and the home assistant server are on the same network. | |||
There was a problem hiding this comment.
Fix capitalization and enhance firmware specification.
- The term "home assistant" should be capitalized as "Home Assistant".
- Consider adding a link to the Tasmota32 webcam firmware documentation for better user guidance.
-The camera functionality in ESP32 Tasmota devices with tasmota32-webcam firmware will be added as Home Assistant `Camera` entities. Note that this functionality is supported only when the Tasmota device and the home assistant server are on the same network.
+The camera functionality in ESP32 Tasmota devices with [tasmota32-webcam firmware](https://tasmota.github.io/docs/ESP32-webcam) will be added as Home Assistant `Camera` entities. Note that this functionality is supported only when the Tasmota device and the Home Assistant server are on the same network.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - The camera functionality in ESP32 Tasmota devices with tasmota32-webcam firmware will be added as Home Assistant `Camera` entities. Note that this functionality is supported only when the Tasmota device and the home assistant server are on the same network. | |
| The camera functionality in ESP32 Tasmota devices with [tasmota32-webcam firmware](https://tasmota.github.io/docs/ESP32-webcam) will be added as Home Assistant `Camera` entities. Note that this functionality is supported only when the Tasmota device and the Home Assistant server are on the same network. |
🧰 Tools
🪛 GitHub Actions: home-assistant.io Test
[error] 49-49: Incorrect usage of the term: "home assistant", use "Home Assistant" instead
| @@ -33,10 +33,11 @@ | |||
| - Tasmota devices flashed with version 9.2, or later (`tasmota-lite.bin` does not support this integration). | |||
| - Tasmota devices configured for native discovery (`SetOption19 0`). | |||
| - Although the Tasmota integration supports custom fulltopic it is strongly suggested to leave fulltopic at its default, Tasmota does not prevent setting an invalid or non-unique fulltopic, for example a fulltopic without the `%prefix%` or `%topic%` tokens. | |||
| - The `Camera` functionality of tasmota32-webcam based devices is supported only when the Tasmota device and the home assistant server are on the same local network. | |||
There was a problem hiding this comment.
Fix capitalization and improve clarity.
The term "home assistant" should be capitalized as "Home Assistant". Also, consider rephrasing for better clarity.
-The `Camera` functionality of tasmota32-webcam based devices is supported only when the Tasmota device and the home assistant server are on the same local network.
+The `Camera` functionality of tasmota32-webcam based devices is supported only when the Tasmota device and the Home Assistant server are on the same local network.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - The `Camera` functionality of tasmota32-webcam based devices is supported only when the Tasmota device and the home assistant server are on the same local network. | |
| The `Camera` functionality of tasmota32-webcam based devices is supported only when the Tasmota device and the Home Assistant server are on the same local network. |
🧰 Tools
🪛 GitHub Actions: home-assistant.io Test
[error] 36-36: Incorrect usage of the term: "home assistant", use "Home Assistant" instead
Proposed change
Enables the support for Tasmota webcam.
ESP32-cam (and other esp32 variants with camera support) have been around for a while and the tasmota32-webcam firmware has been stable.
The HA integration supports the other entity types, but the camera support is not available.
While esphome integration supports esp32-cam, tasmota firmware has many other well-documented features that can be controlled by mqtt.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit