Poll the absolute path of the manifest.json file #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a relative path to manifest.json use an absolut path. This makes sure that we detect that Home Assistant Core is available also on our Apps, which navigate to `/auth/authorize?...` by default. The relative path then polls the wrong location `/auth/manifest.json`. With the absolut path we make sure that the correct location is polled on our Apps as well.
agners
changed the title
sairon
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a relative path to manifest.json use an absolute path. This makes sure that we detect that Home Assistant Core is available also on our Apps, which navigate to
/auth/authorize?...by default. The relative path then polls the wrong location/auth/manifest.json.With the absolute path we make sure that the correct location is polled on our Apps as well.
Fixes: home-assistant/android#4576