Check host network connectivity #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check host network connectivity and offer DNS alternatives in case host internet is not available. This allows users with broken DNS setup to configure the host network with a working DNS. Requires home-assistant/supervisor#5321.
agners
force-pushed
the
check-host-network-connectivity
branch
from
bb84def to
97194ee
Compare
bramkragten
reviewed
Oct 7, 2024
bramkragten
reviewed
Oct 7, 2024
bramkragten
reviewed
Oct 7, 2024
bramkragten
reviewed
Oct 7, 2024
bramkragten
reviewed
Oct 7, 2024
Co-authored-by: Bram Kragten <[email protected]>
All consts need to be assigned on creation. This is not possible in this case.
bramkragten
reviewed
Oct 7, 2024
bramkragten
reviewed
Oct 7, 2024
The idea is to call schedule() always, no matter if there is an error or not. So call it outside of the then() block.
bramkragten
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check host network connectivity and offer DNS alternatives in case host internet is not available. This allows users with broken DNS setup to configure the host network with a working DNS.
Requires home-assistant/supervisor#5321.