Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer.json to use the new format #4665

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

agners
Copy link
Member

@agners agners commented Nov 2, 2023

Proposed change

Use the new structure used by VSCode. Also drop deprecated configurations. The tools inside the devcontainer seem to get picked up by Visual Studio Code automatically, without the need of customizing paths.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Use the new structure used by VSCode. Also drop deprecated
configurations. The tools inside the devcontainer seem to get picked up by
Visual Studio Code automatically, without the need of customizing paths.
@agners agners added the chore label Nov 2, 2023
@agners agners added build Changes that affect the build system and removed chore labels Nov 2, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@frenck frenck merged commit a0c12e7 into main Nov 3, 2023
25 checks passed
@frenck frenck deleted the update-devcontainer-json branch November 3, 2023 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Changes that affect the build system cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants