-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump orjson from 3.9.15 to 3.10.6 #5169
Conversation
This should be mergeable now @agners |
What means should here 😅 I mean, since these were CPU specific failures, it's kinda hard to prove that it works in every configuration right? I am just worried since Supervisor auto-updates that we brick actual intsallations. From what I can tell Core 2024.7.2 and current dev are still on 3.9.15. I'd rather prefer Core to go ahead and test the waters, as Core can be rolled back easier (or rather, Supervisor should roll back in case orjson causes Core to crash early). |
core is out and we haven't had any reports. I think we are probably ok with this one but should wait a few more days. |
Superseded by #5238. |
Cool! Yeah waiting a couple of days make sense. We don't intend to ship a release the next few days, so let's merge this now and then go from there. I did see that there is 3.10.7 already, but there are some SIMD optimization/changes again 😅. I prefer to go with this proven version now, so reopening and merging. |
WalkthroughWalkthroughThe primary change involves updating the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Bumps [orjson](https://github.com/ijl/orjson) from 3.9.15 to 3.10.6. - [Release notes](https://github.com/ijl/orjson/releases) - [Changelog](https://github.com/ijl/orjson/blob/master/CHANGELOG.md) - [Commits](ijl/orjson@3.9.15...3.10.6) --- updated-dependencies: - dependency-name: orjson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
16fb394
to
90dad88
Compare
Bumps orjson from 3.9.15 to 3.10.6.
Release notes
Sourced from orjson's releases.
Changelog
Sourced from orjson's changelog.
... (truncated)
Commits
c24e4ab
3.10.6c369ea4
str various refactor and perf9382058
xxh3_64()95c86e5
cargo update, build misc7b081e1
3.10.56b626c9
dict, list full impl05fd9e1
str escape u8 instead of u647f212b8
3.10.4c96351f
cargo update, miscac8d90e
Module specifies Py_MOD_GIL_USEDYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit
orjson
library to the latest version, enhancing JSON serialization performance and functionality.