Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump orjson from 3.9.15 to 3.10.6 #5169

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2024

Bumps orjson from 3.9.15 to 3.10.6.

Release notes

Sourced from orjson's releases.

3.10.6

Changed

  • Improve performance.

3.10.5

Changed

  • Improve performance.

3.10.4

Changed

  • Improve performance.

3.10.3

Changed

  • manylinux amd64 builds include runtime-detected AVX-512 str implementation.
  • Tests now compatible with numpy v2.

3.10.2

Fixed

  • Fix crash serializing str introduced in 3.10.1.

Changed

  • Improve performance.
  • Drop support for arm7.

3.10.1

Fixed

  • Serializing numpy.ndarray with non-native endianness raises orjson.JSONEncodeError.

Changed

  • Improve performance of serializing.

3.10.0

Changed

  • Support serializing numpy.float16 (numpy.half).
  • sdist uses metadata 2.3 instead of 2.1.
  • Improve Windows PyPI builds.
Changelog

Sourced from orjson's changelog.

3.10.6 - 2024-07-02

Changed

  • Improve performance.

3.10.5 - 2024-06-13

Changed

  • Improve performance.

3.10.4 - 2024-06-10

Changed

  • Improve performance.

3.10.3 - 2024-05-03

Changed

  • manylinux amd64 builds include runtime-detected AVX-512 str implementation.
  • Tests now compatible with numpy v2.

3.10.2 - 2024-05-01

Fixed

  • Fix crash serializing str introduced in 3.10.1.

Changed

  • Improve performance.
  • Drop support for arm7.

3.10.1 - 2024-04-15

Fixed

  • Serializing numpy.ndarray with non-native endianness raises orjson.JSONEncodeError.

Changed

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Summary by CodeRabbit

  • Chores
    • Updated the orjson library to the latest version, enhancing JSON serialization performance and functionality.

@dependabot dependabot bot added dependencies Updates of external dependencies python Pull requests that update Python code labels Jul 3, 2024
@frenck
Copy link
Member

frenck commented Jul 4, 2024

This should be mergeable now @agners

@agners
Copy link
Member

agners commented Jul 17, 2024

This should be mergeable now @agners

What means should here 😅

I mean, since these were CPU specific failures, it's kinda hard to prove that it works in every configuration right? I am just worried since Supervisor auto-updates that we brick actual intsallations. From what I can tell Core 2024.7.2 and current dev are still on 3.9.15. I'd rather prefer Core to go ahead and test the waters, as Core can be rolled back easier (or rather, Supervisor should roll back in case orjson causes Core to crash early).

@agners agners marked this pull request as draft July 17, 2024 14:55
@bdraco
Copy link
Member

bdraco commented Aug 8, 2024

core is out and we haven't had any reports. I think we are probably ok with this one but should wait a few more days.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 9, 2024

Superseded by #5238.

@dependabot dependabot bot closed this Aug 9, 2024
@dependabot dependabot bot deleted the dependabot/pip/orjson-3.10.6 branch August 9, 2024 06:11
@agners agners restored the dependabot/pip/orjson-3.10.6 branch August 9, 2024 09:02
@agners
Copy link
Member

agners commented Aug 9, 2024

core is out and we haven't had any reports. I think we are probably ok with this one but should wait a few more days.

Cool!

Yeah waiting a couple of days make sense. We don't intend to ship a release the next few days, so let's merge this now and then go from there.

I did see that there is 3.10.7 already, but there are some SIMD optimization/changes again 😅. I prefer to go with this proven version now, so reopening and merging.

@agners agners reopened this Aug 9, 2024
@agners agners marked this pull request as ready for review August 9, 2024 09:03
Copy link

coderabbitai bot commented Aug 9, 2024

Walkthrough

Walkthrough

The primary change involves updating the orjson package version in the requirements.txt file from 3.9.15 to 3.10.6. This update aims to leverage improvements and new features in the newer version, potentially enhancing JSON serialization capabilities within the project. No other dependencies were altered, indicating a focused modification aimed at improving performance or functionality.

Changes

File Changes Summary
requirements.txt Updated orjson version from 3.9.15 to 3.10.6

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4c3f60c and 90dad88.

Files selected for processing (1)
  • requirements.txt (1 hunks)
Additional comments not posted (1)
requirements.txt (1)

18-18: Version update approved.

The update of orjson from version 3.9.15 to 3.10.6 is a focused change aimed at leveraging performance improvements and compatibility updates. Ensure that the system is tested for any potential issues related to this update.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Bumps [orjson](https://github.com/ijl/orjson) from 3.9.15 to 3.10.6.
- [Release notes](https://github.com/ijl/orjson/releases)
- [Changelog](https://github.com/ijl/orjson/blob/master/CHANGELOG.md)
- [Commits](ijl/orjson@3.9.15...3.10.6)

---
updated-dependencies:
- dependency-name: orjson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@agners agners force-pushed the dependabot/pip/orjson-3.10.6 branch from 16fb394 to 90dad88 Compare August 9, 2024 09:04
@agners agners merged commit 218ba36 into main Aug 9, 2024
19 checks passed
@agners agners deleted the dependabot/pip/orjson-3.10.6 branch August 9, 2024 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Updates of external dependencies python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants