Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.10.2, drop aiohttp-fast-url-dispatcher #5236

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 8, 2024

Proposed change

aiohttp-fast-url-dispatcher is not needed for 3.10.x

changelog: aio-libs/aiohttp@v3.9.5...v3.10.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Summary by CodeRabbit

  • Chores
    • Updated project dependencies, upgrading aiohttp to version 3.10.2 and removing the aiohttp-fast-url-dispatcher package.
    • Simplified URL dispatching logic within the application, potentially leading to improved routing efficiency.

aiohttp-fast-url-dispatcher is not needed for 3.10.x

changelog: aio-libs/aiohttp@v3.9.5...v3.10.2
@bdraco bdraco added the dependencies Updates of external dependencies label Aug 8, 2024
@bdraco bdraco marked this pull request as ready for review August 8, 2024 20:01
Copy link

coderabbitai bot commented Aug 8, 2024

Walkthrough

Walkthrough

The project has undergone significant dependency updates, specifically upgrading the aiohttp library to version 3.10.2 and removing the aiohttp-fast-url-dispatcher module. This streamlining of dependencies aims to simplify the routing logic in the application, potentially enhancing maintainability while preserving core functionality.

Changes

Files Change Summary
requirements.txt Upgraded aiohttp from 3.9.5 to 3.10.2 and removed aiohttp-fast-url-dispatcher dependency.
supervisor/api/__init__.py Removed imports and initialization related to FastUrlDispatcher, indicating a shift in URL dispatching.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5b46235 and 8689410.

Files selected for processing (2)
  • requirements.txt (1 hunks)
  • supervisor/api/init.py (2 hunks)
Files skipped from review due to trivial changes (1)
  • supervisor/api/init.py
Additional comments not posted (2)
requirements.txt (2)

2-2: Verify compatibility with aiohttp version 3.10.2.

Ensure that the application and its dependencies are compatible with aiohttp version 3.10.2. Check for any deprecated features or API changes that might affect the application.


2-2: Ensure removal of aiohttp-fast-url-dispatcher does not impact functionality.

Verify that the removal of aiohttp-fast-url-dispatcher does not break any routing logic or other functionality in the application.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bdraco
Copy link
Member Author

bdraco commented Aug 8, 2024

I upgraded my production system and didn't see any issues.

@bdraco
Copy link
Member Author

bdraco commented Aug 8, 2024

esphome and google drive backup addons still work as expected.

esphome is a good test because of the websocket forwarding

@agners agners merged commit 4c3f60c into main Aug 9, 2024
19 of 20 checks passed
@agners agners deleted the aiohttp_3102 branch August 9, 2024 08:44
@bdraco
Copy link
Member Author

bdraco commented Aug 9, 2024

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependencies Updates of external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants