Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pre-commit ruff to 0.5.7 and reformat #5242

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

agners
Copy link
Member

@agners agners commented Aug 13, 2024

Proposed change

The codebase is formatted with ruff v0.2.1 currently. This PR reformats the codebase with ruff 0.5.7 and bumps the ruff version used in pre-commit to v0.5.7.

This also addresses the following deprecation warning:

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'flake8-tidy-imports' -> 'lint.flake8-tidy-imports'
  - 'flake8-import-conventions' -> 'lint.flake8-import-conventions'
  - 'flake8-pytest-style' -> 'lint.flake8-pytest-style'
  - 'isort' -> 'lint.isort'
  - 'mccabe' -> 'lint.mccabe'
  - 'per-file-ignores' -> 'lint.per-file-ignores'

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@agners agners added the chore label Aug 13, 2024
@agners agners force-pushed the re-format-with-ruff branch 2 times, most recently from 7d05e50 to ee8b550 Compare August 13, 2024 13:42
It seems that the codebase is not formatted with the latest ruff
version. This PR reformats the codebase with ruff 0.5.7.
@agners agners force-pushed the re-format-with-ruff branch from ee8b550 to ec3871a Compare August 13, 2024 13:50
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@agners agners merged commit f6faa18 into main Aug 13, 2024
19 checks passed
@agners agners deleted the re-format-with-ruff branch August 13, 2024 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants