Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cosign to v2.4.0 #5263

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Bump cosign to v2.4.0 #5263

merged 1 commit into from
Aug 21, 2024

Conversation

agners
Copy link
Member

@agners agners commented Aug 21, 2024

Proposed change

Follow the builder bump of 2024.08.2 and use cosign v2.4.0 for Supervisor too (changelog v2.2.3...v2.4.0)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Summary by CodeRabbit

  • New Features

    • Upgraded the cosign tool to version v2.4.0, which may include enhanced features, improvements, and security updates for signing and verifying container images.
  • Bug Fixes

    • Updated dependencies to improve overall performance and compatibility within the CI/CD pipeline.

Follow the builder bump of 2024.08.2 and use cosign v2.4.0 for
Supervisor too.
@agners agners added the dependencies Updates of external dependencies label Aug 21, 2024
Copy link

coderabbitai bot commented Aug 21, 2024

Walkthrough

The recent updates involve upgrading the version of the cosign tool across multiple configuration files in the GitHub Actions workflows and the Home Assistant Supervisor. The version has been changed from v2.2.3 to v2.4.0, which may introduce new features, security enhancements, or bug fixes. This upgrade aims to improve the overall functionality and security of the CI/CD processes without altering the existing control flow.

Changes

Files Change Summary
.github/workflows/builder.yml, .github/workflows/ci.yaml Updated cosign-release from v2.2.3 to v2.4.0 to enhance security and functionality.
build.yaml Changed COSIGN_VERSION from 2.2.3 to 2.4.0, likely improving build and runtime behavior.

Poem

🐇 In fields of code I hop and play,
With cosign bright, we pave the way.
From version two-point-two to four,
New features bloom, oh, what a score!
With each sweet change, our work we’ll cheer,
Hopping high for progress near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 12d26b0 and 4b7b59c.

Files selected for processing (3)
  • .github/workflows/builder.yml (1 hunks)
  • .github/workflows/ci.yaml (1 hunks)
  • build.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/ci.yaml
Additional comments not posted (2)
build.yaml (1)

15-15: Version bump approved for COSIGN_VERSION.

The update from 2.2.3 to 2.4.0 reflects a standard version bump to ensure the latest features and security patches are utilized.

.github/workflows/builder.yml (1)

136-136: Version bump approved for cosign-release.

The update from v2.2.3 to v2.4.0 ensures that the workflow uses the latest version of cosign, potentially benefiting from new features and security improvements.

@mdegat01 mdegat01 merged commit 5117364 into main Aug 21, 2024
20 checks passed
@mdegat01 mdegat01 deleted the bump-cosign-to-v2.4.0 branch August 21, 2024 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependencies Updates of external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants