Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astroid to pytest requirements #5506

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

agners
Copy link
Member

@agners agners commented Dec 23, 2024

Proposed change

Currently astroid is installed implicitly as a dependency of pylint. However, it seems that the latest release 3.3.7 actually causes issue for pylint.

To avoid accidential breakage by astroid let's add it to the test requirements and fix it to the last known working version 3.3.6.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:
  • Link to client library pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

Summary by CodeRabbit

  • New Features
    • Introduced new testing dependencies for enhanced functionality and performance.
    • Added support for various testing frameworks and tools, including pytest, coverage, and pylint.

Currently astroid is installed implicitly as a dependency of pylint.
However, it seems that the latest release 3.3.7 actually causes issue
for pylint.

To avoid accidential breakage by astroid let's add it to the test
requirements and fix it to the last known working version 3.3.6.
@agners agners added the dependencies Updates of external dependencies label Dec 23, 2024
@agners agners mentioned this pull request Dec 23, 2024
14 tasks
Copy link

coderabbitai bot commented Dec 23, 2024

📝 Walkthrough

Walkthrough

The pull request updates the requirements_tests.txt file by adding and specifying exact versions for multiple testing and development dependencies. These dependencies include testing frameworks like pytest and its plugins, code quality tools such as pylint and ruff, coverage reporting tools, and utility packages like time-machine and typing extensions. The update ensures consistent and precise dependency management for the project's testing environment.

Changes

File Changes
requirements_tests.txt Added dependencies with specific versions:
- astroid==3.3.6
- coverage==7.6.9
- pre-commit==4.0.1
- pylint==3.3.2
- pytest-aiohttp==1.0.5
- pytest-asyncio==0.23.6
- pytest-cov==6.0.0
- pytest-timeout==2.3.1
- pytest==8.3.4
- ruff==0.8.4
- time-machine==2.16.0
- typing_extensions==4.12.2
- urllib3==2.2.3

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5993818 and bf3cc59.

📒 Files selected for processing (1)
  • requirements_tests.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • requirements_tests.txt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck merged commit 53ccc52 into main Dec 23, 2024
21 checks passed
@frenck frenck deleted the add-astroid-to-test-requirements branch December 23, 2024 11:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependencies Updates of external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants