Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Sticky" sensors confuse economizer process control logic #290

Closed
climategadgets opened this issue Oct 7, 2023 · 1 comment
Closed

"Sticky" sensors confuse economizer process control logic #290

climategadgets opened this issue Oct 7, 2023 · 1 comment
Labels
$$$ bug economizer fault tolerance hardware driver process control reactive Pertinent to Reactive branches only Z-Wave

Comments

@climategadgets
Copy link
Member

climategadgets commented Oct 7, 2023 •
edited
Loading

Expected Behavior

Sensor abstractions emit sensor data if available, error signal if not, on a defined rate.

Actual Behavior

Under undetermined circumstances, a sensor signal processing pipeline keeps emitting a stale reading as current, causing control logic to issue improper actuator signals. Meanwhile, sensors are working as expected, they are not the root cause.

Manifestation

Painfully obvious.
image

Root Cause Analysis

At this point, it appears that the culprit is a flaky Z-Wave device - Minoston MP31ZP.

Workaround

For now see if using the optimistic flag in the configuration fixes the problem, however, hardware replacement is recommended. See Hardware Support for suitable replacements.

Related Issues

#280 , #292
@climategadgets climategadgets changed the title "Sticky" sensors confuse process control logic "Sticky" sensors confuse economizer process control logic Oct 8, 2023
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Removed questionable subscribeOn() (#271, #290)
883bd0c
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Added diagnostics and safety checks in the economizer pipeline (#290)
d27d0e8
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Added diagnostics and safety checks in the economizer pipeline (#290)
8c3b507
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Added diagnostics and safety checks in the economizer pipeline (#290)
f701a58
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Added diagnostics and safety checks in the economizer pipeline (#290)
2cd28f7
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Improved diagnostics on TimeoutGuard (#271, #290)
fa42488
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Assuring non-null ID on TimeoutGuard (#271, #290)
7983d71
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Added diagnostics to TimeoutGuard (#271, #290)
7e03c30
climategadgets added a commit that referenced this issue Oct 9, 2023
@climategadgets
Added more diagnostics (#271, #290)
1bb1757
climategadgets added a commit that referenced this issue Oct 9, 2023
@climategadgets
Identified race condition, not necessarily related to #290 (#271)
e08b5f4
climategadgets added a commit that referenced this issue Oct 9, 2023
@climategadgets
More diagnostics (#271, #290)
9bc34aa
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Removed redundant argument (#238, #290)
d09a207
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix that broke everything (details below) (#238, #271, #290)
fc34be5 
Original problem: feedback wasn't engaged when economizer wasn't configured
due to a typo

Collateral and deal breaker: fixing the bug makes test cases stall, though
the application somehow keeps working.

This very likely pinpoints the root cause of #290.
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix, complication (details below) (#238, #271, #290)
315d554 
Original problem: feedback wasn't engaged when economizer wasn't configured
due to a typo

Collateral: feedbackFlux is not closed, this is why test cases stall.  Fix
is in the next commit.
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix complication removed (fixed test cases) (#238, #271, #290)
71a8438
@climategadgets climategadgets mentioned this issue Oct 11, 2023
Closed
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Documentation update (#280, #290)
ca79985
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Merge branch 'gh290-rca' into dev (#290)
ae01f0e
climategadgets added a commit that referenced this issue Oct 12, 2023
@climategadgets
Moved bugfix (rev. 71a8438) into a better place (#238, #271, #290)
e4d4798
climategadgets added a commit that referenced this issue Oct 12, 2023
@climategadgets
Merge branch 'gh290-rca' into dev (#290)
6f051c3
@climategadgets climategadgets mentioned this issue Oct 12, 2023
Closed
@climategadgets
Copy link
Member Author

Root cause identified, device replaced, continuing operation normally. Follow up and corrective action in #292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$$ bug economizer fault tolerance hardware driver process control reactive Pertinent to Reactive branches only Z-Wave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@climategadgets