maven-gpg-plugin for 1.10.2

homebeaver · Dec 16, 2024 · 02dac8d · 02dac8d
1 parent 91710b9
commit 02dac8d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/.github/workflows/maven_deploy.yml b/.github/workflows/maven_deploy.yml
@@ -28,13 +28,12 @@ jobs:
           server-id: ossrh # Value of the distributionManagement/repository/id field of the pom.xml
           server-username: MAVEN_USERNAME
           server-password: MAVEN_PASSWORD
-          # TODO:
-#          gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }} # has to be read directly from secrets
-#          gpg-passphrase: MAVEN_GPG_PASSPHRASE # default name used by maven-gpg-plugin
+          gpg-private-key: ${{ secrets.SIGN_KEY }} # has to be read directly from secrets
+          gpg-passphrase: SIGN_KEY_PASS # default name used by maven-gpg-plugin
       - name: Publish package
 #        run: mvn --batch-mode deploy
         run: mvn -V --errors --show-version --batch-mode --no-transfer-progress -Ddoclint=all deploy
         env:
           MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
           MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
-#          MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
+          MAVEN_GPG_PASSPHRASE: ${{ secrets.SIGN_KEY_PASS }}
diff --git a/pom.xml b/pom.xml
@@ -28,7 +28,7 @@
  -->
   <groupId>io.github.homebeaver</groupId> 
   <artifactId>isoiec7064</artifactId>
-  <version>1.10.1</version>
+  <version>1.10.2</version>
   <packaging>jar</packaging>
 
   <name>IsoIec7064</name>
@@ -132,26 +132,22 @@
         </executions>
       </plugin>
 
-<!-- see https://maven.apache.org/plugins/maven-gpg-plugin/usage.html
+<!-- see https://maven.apache.org/plugins/maven-gpg-plugin/usage.html -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-gpg-plugin</artifactId>
         <version>3.2.7</version>
         <executions>
           <execution>
-            <id>sign-artifacts</id>
             <phase>verify</phase>
             <goals>
               <goal>sign</goal>
             </goals>
-            <configuration>
-              <keyname>sign-key-id</keyname>
-              <passphraseServerId>sign-key-id</passphraseServerId>
-            </configuration>
           </execution>
         </executions>
       </plugin>
-use simplify4u : -->
+<!-- or use simplify4u : https://www.simplify4u.org/sign-maven-plugin/
+Key configuration can be provided by environment variables: SIGN_KEY, SIGN_KEY_ID, SIGN_KEY_PASS
       <plugin>
         <groupId>org.simplify4u.plugins</groupId>
         <artifactId>sign-maven-plugin</artifactId>
@@ -161,13 +157,10 @@ use simplify4u : -->
                 <goals>
                     <goal>sign</goal>
                 </goals>
-                <configuration>
-                    <!-- the same id as in settings.xml -->
-                    <serverId>sign-key-id</serverId>
-                </configuration>
             </execution>
         </executions>
       </plugin>
+ -->
 
       <plugin>
          <groupId>org.apache.maven.plugins</groupId>