bump the default node version from 20 to 22

homebridge · Oct 26, 2024 · 37289c2 · 37289c2
1 parent 640c821
commit 37289c2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -39,6 +39,7 @@ Plugin developers:
 - retire use of `pnpm` and code references
 - check for service mode when querying child bridge status
 - enable strict config validation for the UI
+- bump the default node version from 20 to 22
 
 ### Homebridge Dependencies
 

diff --git a/src/modules/status/status.service.ts b/src/modules/status/status.service.ts
@@ -468,7 +468,6 @@ export class StatusService {
 
       // Get the newest v18 and v20 in the list
       const latest18 = versionList.filter((x: { version: string }) => x.version.startsWith('v18'))[0]
-      const latest20 = versionList.filter((x: { version: string }) => x.version.startsWith('v20'))[0]
       const latest22 = versionList.filter((x: { version: string }) => x.version.startsWith('v22'))[0]
 
       let updateAvailable = false
@@ -481,25 +480,26 @@ export class StatusService {
        *
        *      18            2.28
        *      20            2.31
+       *      22            2.31 (assumption - the code below assumes this)
        */
 
       // Behaviour depends on the installed version of node
       switch (process.version.split('.')[0]) {
         case 'v18': {
-          // Currently using v18, but v20 is available
+          // Currently using v18, but v22 is available
           // If the user is running linux, then check their glibc version
-          //   If they are running glibc 2.31 or higher, then show the option to update to v20
+          //   If they are running glibc 2.31 or higher, then show the option to update to v22
           //   Otherwise we would still want to see if there is a minor/patch update available for v18
-          // Otherwise, already show the option for updating to node 20
+          // Otherwise, already show the option for updating to node 22
           if (platform() === 'linux') {
             const glibcVersion = this.getGlibcVersion()
             if (glibcVersion) {
               if (Number.parseFloat(glibcVersion) >= 2.31) {
-                // glibc version is high enough to support v20
+                // glibc version is high enough to support v22
                 updateAvailable = true
-                latestVersion = latest20.version
+                latestVersion = latest22.version
               } else {
-                // glibc version is too low to support v20
+                // glibc version is too low to support v22
                 // Check if there is a new minor/patch version available
                 if (gt(latest18.version, process.version)) {
                   updateAvailable = true
@@ -513,19 +513,17 @@ export class StatusService {
               }
             }
           } else {
-            // Not running linux, so show the option for updating to node 20
+            // Not running linux, so show the option for updating to node 22
             updateAvailable = true
-            latestVersion = latest20.version
+            latestVersion = latest22.version
           }
           break
         }
         case 'v20': {
           // Currently using v20
-          // Check if there is a new minor/patch version available
-          if (gt(latest20.version, process.version)) {
-            updateAvailable = true
-            latestVersion = latest20.version
-          }
+          // Show the option for updating to node 22
+          updateAvailable = true
+          latestVersion = latest22.version
           break
         }
         case 'v22': {