Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack5 #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

carlosmaniero
Copy link

@carlosmaniero carlosmaniero commented Mar 5, 2021

Webpack 5 "differentiates between files and auxiliaryFiles now." - https://webpack.js.org/blog/2020-10-10-webpack-5-release/

It was not need to create a new test since css-map-entry covers this scenario. The test break after the upgrade so I just needed to make it pass 😃

Other changes:

  • I upgraded jest which requires node 10 >
  • I removed the hardcoded npm version from pipeline because the version defined breaks with node 10.
  • I also add an opt-out flag for logging.

@carlosmaniero
Copy link
Author

Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant