Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix HdPhoneInput component missing country flag icons #1260

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

aym3nb
Copy link
Contributor

@aym3nb aym3nb commented Feb 26, 2024

Main changes

  • Fetch flag-icons-svg files from CDN instead of locally to ensure they show up in consuming projects and to avoid increasing HdPhoneInput component size further

Additional changes

  • Update outdated snapshots
  • Remove flag-icons-svg

Screenshot 2024-02-27 at 08 54 50

@aym3nb aym3nb self-assigned this Feb 26, 2024
Copy link

github-actions bot commented Feb 26, 2024

🚮 The files previously deployed on /homeday-blocks/1260/ were already removed.

@aym3nb aym3nb changed the title 🚧 Fix missing flag icons 🐛 Fix HdPhoneInput component missing country flag icons Feb 27, 2024
@aym3nb aym3nb marked this pull request as ready for review February 27, 2024 07:51
@aym3nb aym3nb merged commit bfb7b2c into master Feb 27, 2024
3 checks passed
@aym3nb aym3nb deleted the bugfix/missing-flag-icons branch February 27, 2024 09:55
@homeday-bot
Copy link
Collaborator

🎉 This PR is included in version 19.17.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants