Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.31.x #6

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Release 1.31.x #6

merged 3 commits into from
Jan 6, 2025

Conversation

ryanjohnsontv
Copy link

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.


Helpful Tips

Add screenshots and annotations

Add a gif to show an action

GIFs are great to show an action, however they sometimes move too fast.
One way to improve them is to capture 3 pieces of content:

  • screenshot before an action
  • screenshot after the action
  • gif of the action
  • You can edit a gif using https://ezgif.com/

Put a border around a screenshot/gif

Add a border to help improve the readability.

<kbd>![](https://www.spinnaker.io/assets/images/spinnaker-logo-inline.svg)</kbd>

Add expandable sections

Add expandable sections to hide away large code blocks/images or reduce the motion of a gifs
const example = 'spinnaker spinnaker SPINNAKER';

packages/dcos/src/job/general.component.js Dismissed Show dismissed Hide dismissed
packages/dcos/src/job/general.component.js Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@guido9j guido9j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanjohnsontv ryanjohnsontv merged commit fcd7a08 into main Jan 6, 2025
2 checks passed
@ryanjohnsontv ryanjohnsontv deleted the release-1.31.x branch January 6, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants