Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param support for payload configurations #50

Conversation

joshbrucker
Copy link
Contributor

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • Code cleanup
  • New feature
  • Other (please explain):

Addresses #
N/A

What changes did you make? (Give a brief overview)
For every GitHub webhook, there are payload settings that can be configured. These are the payload destination address, the payload serialization format, and a payload secret. This PR adds these three fields as configurable values in the put step of the Concourse resource. All fields are optional, and if they are not explicitly passed in, the behavior remains the same as it currently is (pulled from env vars set by Concourse).

Also, in the config parameter passed into the GitHub API call, the key content-type has been changed to the correct key content_type, as demonstrated in the GitHub API docs.

Is there anything specific you would like reviewers to focus on?
N/A

@joshbrucker
Copy link
Contributor Author

@billimek @GavinFigueroa The above feature has been implemented and tested - it's now ready for review.

Copy link
Member

@billimek billimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billimek
Copy link
Member

Thanks for making this contribution!

@billimek billimek merged commit 8958436 into homedepot:master Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants