Add tests for cached state identify unsupported check

[DCSBL]

Summary by CodeRabbit

• New Features

  • Enhanced method support checks for state and identify operations in HomeWizard Energy devices

• Tests

  • Added test coverage for unsupported state and identify operations on cached devices

• Bug Fixes

  • Improved method calls to correctly determine device feature support

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the HomeWizardEnergyV1 class in the homewizard_energy/v1/__init__.py file, focusing on updating the method calls for checking device support for state and identification features. Instead of using boolean attribute checks, the changes now invoke specific methods supports_state() and supports_identify(). Corresponding test cases have been added to tests/v1/test_v1_homewizard_energy.py to validate the behavior of these methods when called on devices that do not support state changes or identification.

Changes

File	Change Summary
homewizard_energy/v1/__init__.py	- Updated state method to use self._device.supports_state() instead of self._device.supports_state is False - Updated identify method to use self._device.supports_identify() instead of self._device.supports_identify is False - Added comment in system method about legacy error handling
tests/v1/test_v1_homewizard_energy.py	- Added test_state_not_supported_with_cached_device test function - Added test_identify_not_supported_with_cached_device test function - Implemented parameterized test cases for both new test functions

Sequence Diagram

sequenceDiagram
    participant Client
    participant HomeWizardEnergyV1
    participant Device
    
    Client->>HomeWizardEnergyV1: state() or identify()
    HomeWizardEnergyV1->>Device: supports_state() or supports_identify()
    Device-->>HomeWizardEnergyV1: Support status
    alt Not Supported
        HomeWizardEnergyV1-->>Client: Raise UnsupportedError
    else Supported
        HomeWizardEnergyV1->>Device: Perform action
        Device-->>HomeWizardEnergyV1: Action result
        HomeWizardEnergyV1-->>Client: Return result
    end

Loading

Possibly related PRs

• Use native arguments for set-functions and route led_brightness to state for v1 API #460: Updates to the state method in the HomeWizardEnergy class, directly related to method modifications
• Remove handing of non-200 in v1 state/system calls, already handled by _request #465: Modifications to the HomeWizardEnergyV1 class, specifically state and system methods, aligning with the current changes

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88c016f and c91e43b.

📒 Files selected for processing (2)

• homewizard_energy/v1/__init__.py (2 hunks)
• tests/v1/test_v1_homewizard_energy.py (2 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (88c016f) to head (c91e43b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   98.51%   99.25%   +0.74%     
==========================================
  Files           8        8              
  Lines         539      539              
  Branches       38       38              
==========================================
+ Hits          531      535       +4     
+ Misses          5        3       -2     
+ Partials        3        1       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.