feat(js): reload unhandledRejection and uncaughtException plugins on configure #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyBerkowitz
commented
Sep 7, 2023
| @@ -22,14 +22,6 @@ export default class UncaughtExceptionMonitor { | |||
| makeListener() { | |||
| const honeybadgerUncaughtExceptionListener = (uncaughtError: Error) => { | |||
| if (this.__isReporting || !this.__client) { return } | |||
|
|
|||
| if (!this.__client.config.enableUncaught) { | |||
There was a problem hiding this comment.
Redundant now that the listener is removed in this case
BethanyBerkowitz
commented
Sep 7, 2023
| @@ -18,13 +18,6 @@ export default class UnhandledRejectionMonitor { | |||
|
|
|||
| makeListener() { | |||
| const honeybadgerUnhandledRejectionListener = (reason: unknown, _promise: Promise<unknown>) => { | |||
| if (!this.__client || !this.__client.config.enableUnhandledRejection) { | |||
There was a problem hiding this comment.
Redundant now that the listener is removed in this case.
I'd only included !this.__client here because typescript wouldn't let me check !this.__client.config.enableUnhandledRejection otherwise.
BethanyBerkowitz
commented
Sep 7, 2023
| expect(Singleton.config.__plugins.length).toBe(2) | ||
| }) | ||
|
|
||
| it('clients produced via factory don\'t include plugins', function () { |
There was a problem hiding this comment.
We are debating whether this is what we want in #1181, but I figured I'd document the current behavior.
Closed
5 tasks
subzero10
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Part of #1163
Core version 6.3.0 includes the ability for plugins to set
shouldReloadOnConfigure. This PR turns that on for theunhandledRejectionanduncaughtExceptionplugins.Related PRs
Listed in #1163
Todos
Steps to Test or Reproduce
cd packages/js npm run test:server