Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(e2e): fix setup #1190

Merged
merged 7 commits into from
Sep 21, 2023
Merged

ci(e2e): fix setup #1190

merged 7 commits into from
Sep 21, 2023

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented Sep 15, 2023 •
edited
Loading

Status

READY

Description

A last minute change in #1171 broke the setup of the integration tests and they wouldn't exit the process when done.

  • If tests fail, upload playwright report as an artefact
  • fix global-teardown.ts
  • refactor global-setup.ts

@subzero10 subzero10 self-assigned this Sep 15, 2023
BethanyBerkowitz
BethanyBerkowitz reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@BethanyBerkowitz BethanyBerkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm but I'm not sure why you now have a test failure after the most recent commit?

@subzero10
Copy link
Member Author

This lgtm but I'm not sure why you now have a test failure after the most recent commit?

I think this was a browserstack fluke (all tests for a single browser failed) - I retried and they passed.

@subzero10 subzero10 merged commit ed61911 into master Sep 21, 2023
@subzero10 subzero10 deleted the playwright-fixes branch September 21, 2023 05:59
@BethanyBerkowitz BethanyBerkowitz mentioned this pull request Sep 21, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyBerkowitz BethanyBerkowitz BethanyBerkowitz approved these changes

Assignees

@subzero10 subzero10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subzero10 @BethanyBerkowitz