Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support . in field names #55

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: support . in field names #55

merged 1 commit into from
May 22, 2024

Conversation

skpy
Copy link
Contributor

@skpy skpy commented May 22, 2024 •
edited by kentquirk
Loading

Which problem is this PR solving?

Short description of the changes

  • This adds . to the list of characters to match in the constpat regex. This should allow field names to contain dots, allowing us to make more realistic trace data: http.status_code=/st10,0.1, and http.route=/u and the like.

Fixes #53

@skpy skpy requested a review from a team as a code owner May 22, 2024 12:59
@skpy skpy changed the title support . in field names fix: support . in field names May 22, 2024
kentquirk
kentquirk approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@kentquirk kentquirk merged commit a79e715 into honeycombio:main May 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set http.status (or other fields with a .)
2 participants
@skpy @kentquirk