Skip to content

Commit

Permalink
fix: update query annotation name and description max length to refle…
Browse files Browse the repository at this point in the history
…ct recent api change (#601)

## Summary

https://app.asana.com/0/1202029430213430/1208940043616576

In a [previous, Honeycomb internal
PR](honeycombio/hound#21613), we updated the
maximum length for query annotation name and description fields.

Now we update those fields in the terraform provider to keep length
validation consistent.

Along the way, fix a few typos in `CONTRIBUTING.MD`
  • Loading branch information
huntzinger92 authored Jan 21, 2025
1 parent 8647587 commit ae2d483
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ This project uses `golangci-lint` with the configuration at `.golangci.yml` in t

### Run GitHub Actions on your fork

If you fork the repository, you can also run the tests on GitHub Actions (for free since it's a public repository). Unfortunatly there is no mechanism to share secrets, so all runs will fail until the necessary secrets are configured.
If you fork the repository, you can also run the tests on GitHub Actions (for free since it's a public repository). Unfortunately there is no mechanism to share secrets, so all runs will fail until the necessary secrets are configured.

To properly setup the GitHub Actions, add the following secrets:

Expand All @@ -104,14 +104,14 @@ To properly setup the GitHub Actions, add the following secrets:
To release a new version of the Terraform provider a binary has to be built for a list of platforms ([more information](https://developer.hashicorp.com/terraform/registry/providers/publishing#creating-a-github-release)).
This process is largely automated with GoReleaser and GitHub Actions.

The unautomated part is creating a "releast commit" which updates `CHANGELOG.md` in the root of the repository as well as the references to the build version in the various examples.
The unautomated part is creating a "release commit" which updates `CHANGELOG.md` in the root of the repository as well as the references to the build version in the various examples.

Once the release commit has landed on the `main` branch:

- Create a tag following semantic convention prefixed with a `v` (i.e. `v0.83.0`)
- this will start the "release" workflow which builds various versions of the provider for target platforms and architectures.
This can take up to 10 minutes to complete.
- When the release workflow compltes, go to [releases](https://github.com/honeycombio/terraform-provider-honeycombio/releases/) and you'll find a draft release with the build artifacts attached.
- When the release workflow completes, go to [releases](https://github.com/honeycombio/terraform-provider-honeycombio/releases/) and you'll find a draft release with the build artifacts attached.
- Update the release name to match the release tag (i.e. `v0.83.0`)
- Copy the section from `CHANGELOG.md` for this release into the release description.
- Publish the release.
Expand Down
4 changes: 2 additions & 2 deletions honeycombio/resource_query_annotation.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ func newQueryAnnotation() *schema.Resource {
"name": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringLenBetween(1, 80),
ValidateFunc: validation.StringLenBetween(1, 320),
},
"description": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringLenBetween(1, 280),
ValidateFunc: validation.StringLenBetween(1, 1023),
},
},
}
Expand Down

0 comments on commit ae2d483

Please sign in to comment.