Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate random URLs for webhook-like recipients #549

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Sep 24, 2024

The nightly "smoke test" failed last evening for two reasons:

  1. we had an API-side bug when deleting certain shapes of recipients (now fixed)
  2. because of the above, there were recipients that were considered duplicates as their Webhook URLs matched (affects Webhook and MSTeams* recipients). In the name of moving toward being able to run these tests concurrently, this fixes that duplicate issue.

@jharley jharley added the bug label Sep 24, 2024
@jharley jharley requested a review from a team as a code owner September 24, 2024 14:47
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (24c6e3f) to head (4dd18b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   78.78%   78.80%   +0.01%     
==========================================
  Files          86       86              
  Lines        6124     6128       +4     
==========================================
+ Hits         4825     4829       +4     
  Misses        964      964              
  Partials      335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley merged commit 0fb6126 into main Sep 24, 2024
6 checks passed
@jharley jharley deleted the jharley.fix-webhook-dup-rcpt branch September 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants