Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): retry on server errors #571

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Nov 15, 2024

Have the V1 API Client retry on 500-class errors like the V2 client.


@jharley jharley added the bug label Nov 15, 2024
@jharley jharley requested a review from a team as a code owner November 15, 2024 14:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.04%. Comparing base (bec5669) to head (7b47e06).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
client/client.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   76.05%   76.04%   -0.01%     
==========================================
  Files          86       86              
  Lines        7107     7105       -2     
==========================================
- Hits         5405     5403       -2     
  Misses       1368     1368              
  Partials      334      334              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley merged commit d58baef into main Nov 15, 2024
6 checks passed
@jharley jharley deleted the jharley.fix-v1client-retry-on-500 branch November 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants