Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): show only installed package managers in choices #42

Merged
merged 3 commits into from
May 29, 2024

Conversation

6km
Copy link
Contributor

@6km 6km commented May 27, 2024

Check if the package manager is installed by running its command with --version, and only show installed package managers in choices.

@yusukebe
Copy link
Member

Hi @6km

This is awesome!

Looks good, but can we write the test for this feature? It's ok to go without a test if it's super difficult, but I want to check if the choices appear properly.

@6km
Copy link
Contributor Author

6km commented May 28, 2024

@yusukebe I couldn't figure out a good way to add tests for this feature.

now it can check if npm is installed with no issues
@6km
Copy link
Contributor Author

6km commented May 29, 2024

@yusukebe I have tested this locally with npm, pnpm and yarn. It works as expected. Can you test if it can detect bun?

@yusukebe
Copy link
Member

Hi @6km

Yes. It can detect bun! I think we can go with this without adding more tests. Is this ready to merge?

@6km
Copy link
Contributor Author

6km commented May 29, 2024

Hi @yusukebe

Yes. It's ready to merge! 🚀

@yusukebe
Copy link
Member

@6km

Let's gooo! Thanks!

@yusukebe yusukebe merged commit 8d1e723 into honojs:main May 29, 2024
2 checks passed
@6km
Copy link
Contributor Author

6km commented May 29, 2024

@yusukebe You're welcome. More contributions coming in the future, insha'allah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants