Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(main): remove unnecessary forEach #44

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

6km
Copy link
Contributor

@6km 6km commented May 29, 2024

Hi

I have removed the loop that retrieves template names from templateDirs and directly assigned the template names to the templates variable, which now contains the template names.

This change makes the code more readable by reducing the number of lines

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's neat! LGTM!

@yusukebe
Copy link
Member

@6km

Thank you very much! templates/ is not necessary. Merging now.

@yusukebe yusukebe merged commit 997f096 into honojs:main May 30, 2024
2 checks passed
@6km 6km deleted the remove-loop branch May 30, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants