Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): hide install option if no package manager is installed. #46

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

6km
Copy link
Contributor

@6km 6km commented Jun 3, 2024

Hide the install dependencies option if no package manager is installed.
I have tested it manually and it works fine.

Thanks to @ryuapp for pointing out this issue!
Closes #45

@6km 6km changed the title feat(dependencies): show error if no package manager is installed feat(dependencies): hide the install deps option if no package manager is installed. Jun 3, 2024
@6km 6km changed the title feat(dependencies): hide the install deps option if no package manager is installed. feat(dependencies): hide the install dependencies option if no package manager is installed. Jun 3, 2024
@6km 6km changed the title feat(dependencies): hide the install dependencies option if no package manager is installed. feat(dependencies): hide install dependencies option if no package manager is installed. Jun 3, 2024
@6km 6km changed the title feat(dependencies): hide install dependencies option if no package manager is installed. feat(dependencies): hide install option if no package manager is installed. Jun 3, 2024
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jun 3, 2024

Hi @6km !

Thanks! I'll merge this now and release a patch-release v0.8.1 that includes this change. This is a feat and important but it's small change for the user, so it will be a patch-release.

@yusukebe yusukebe merged commit 293536d into honojs:main Jun 3, 2024
2 checks passed
@6km 6km deleted the no-package-manager-installed branch June 3, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide dependency option if no package manager exists
2 participants