Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: projectName for "./" target #72

Merged

Conversation

arturgawlik
Copy link
Contributor

@arturgawlik arturgawlik commented Sep 10, 2024

This small PR fixes minor issue for creating project where as Target directory "./" is provided.

Actual behaviour

project name in package.json is set to "." after providing "./" as Target directory:
image

After fix

after my fix project name in package.json is properly set to current directory name:
image

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yusukebe
Copy link
Member

Hi @arturgawlik

Thank you for the PR!

@MathurAditya724 Can you review this?

Copy link
Contributor

@MathurAditya724 MathurAditya724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting PR, I have left a comment to make this more generic. Thank you

src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@MathurAditya724 MathurAditya724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yusukebe
Copy link
Member

@arturgawlik @MathurAditya724 Thanks! I'll merge it now.

@yusukebe yusukebe merged commit f233bbb into honojs:main Sep 11, 2024
3 checks passed
@arturgawlik arturgawlik deleted the fix-project-name-for-current-dir-with-slash branch September 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants