Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old deno gives an error when using deno -v #75

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Oct 10, 2024

Fix honojs/hono#3503

I’m sorry. Old Deno cannot check the version with -v, causing errors for some users.
This PR fixes to check the version with -V and` not terminate the command if an error occurs.

Ref: denoland/deno#5289 (comment)

@yusukebe
Copy link
Member

@ryuapp Thanks!

@yusukebe yusukebe merged commit cf9e348 into honojs:main Oct 10, 2024
3 checks passed
@ryuapp ryuapp deleted the fix-deno-version-error branch October 10, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun create hono not working because of deno
2 participants