-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/add solana priority fees #4
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
lockedWritableAccounts: uniqAccs, | ||
}); | ||
|
||
return median(recentFees.map(item => item.prioritizationFee)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am no solana expert 😅 Would using lowest value work ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Hedi
Good question :)
I've been thinking about this as well, and after research it looked like median seem be good to approximate priority fees for a given transaction. This ensures that the priority fees is above the lowest but not too wasteful.
Helius Priority Fee API also uses 50th percentile (median) by default.
But it also provides other values, like low (25th) or UNSAFE_MAX (100th).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks !
c2a8189
to
9376144
Compare
9376144
to
71f4ac4
Compare
71f4ac4
to
7a2d926
Compare
.catch(remapErrors); | ||
}, | ||
|
||
getSimulationComputeUnits: async (instructions, payer) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !!!
41adf76
to
6d1e120
Compare
6d1e120
to
b45e489
Compare
1a94823
to
4264875
Compare
666023e
to
cd8eca4
Compare
7d2a396
to
c44b62b
Compare
c44b62b
to
165d255
Compare
165d255
to
ffa441f
Compare
b05a0c7
to
3368cc5
Compare
9c2231a
to
6a299cc
Compare
6a299cc
to
67c2bc9
Compare
253c3f0
to
16d5195
Compare
16d5195
to
378d78b
Compare
378d78b
to
b3150f3
Compare
b3150f3
to
f3de7d7
Compare
f3de7d7
to
1dce47f
Compare
📝 Description
Issue:
https://support.ledger.com/hc/en-us/articles/17531561702813-Temporary-issue-with-Staking-and-Sending-Solana-SOL-in-Ledger-Live-Your-transaction-may-have-failed?support=true
Solution
Advised solution to mitigate this is
Note:
Required
getRecentPrioritizationFees
rpc call doesn't work correctly in@solana/[email protected]
.Hence,
@solana/web3.js
and@solana/spl-token
have been updated.❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.🧐 Checklist for the PR Reviewers