Feature/major update #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor commands into separate class files Fix issue with rotation, fixes rotation of ghost board Performance improvements on generating surfaces and in general Bugfix on surfaces Loads s3dx format View cross section walkthrough in machine view Improved weight calculator
|
Have a look at the stuff I did a while back to see if any of it is useful for you - I added some channel functionality etc. Havent looked at it for a couple of years it feels like. |
Amanda1232
reviewed
Nov 4, 2020
| model.setGeometry(quads); | ||
|
|
||
| } | ||
|
|
||
| public String toString() | ||
| { | ||
| String str = new String(); |
There was a problem hiding this comment.
Our static analysis engine detects that your pull request includes a change that method invokes inefficient new String() constructor. According to the best practice, creating a new java.lang.String object using the no-argument constructor wastes memory because the object so created will be functionally indistinguishable from the empty string constant "". Java guarantees that identical string constants will be represented by the same String object. Therefore, you should just use the empty string constant directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of bug fixes and improvements. Might be time for a new release.