Fix CardAccount and PaymentTerms

horstoeko · Jun 6, 2024 · 6aa55b8 · 6aa55b8
1 parent 51a8944
commit 6aa55b8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/XmlConverterCiiToUbl.php b/src/XmlConverterCiiToUbl.php
@@ -1114,6 +1114,7 @@ function ($paymentMeansTypeCodeNode) use ($peymentMeansNode) {
                     function ($paymentMeansFinancialCardNode) {
                         $this->destination->startElement('cac:CardAccount');
                         $this->destination->element('cbc:PrimaryAccountNumberID', $this->source->queryValue('./ram:ID', $paymentMeansFinancialCardNode));
+                        $this->destination->element('cbc:NetworkID', 'mapped-from-cii');
                         $this->destination->element('cbc:HolderName', $this->source->queryValue('./ram:CardholderName', $paymentMeansFinancialCardNode));
                         $this->destination->endElement();
                     }
@@ -1172,11 +1173,11 @@ private function convertPaymentTerms(): void
         $invoiceHeaderSettlement = $this->source->query('./ram:ApplicableHeaderTradeSettlement', $invoiceSuppyChainTradeTransaction)->item(0);
 
         $this->source->whenExists(
-            './ram:SpecifiedTradePaymentTerms',
+            './ram:SpecifiedTradePaymentTerms/ram:Description[string-length(text()) > 0]',
             $invoiceHeaderSettlement,
-            function ($peymentTermsNode) {
+            function ($peymentTermsDescriptionNode, $peymentTermsNode) {
                 $this->destination->startElement('cac:PaymentTerms');
-                $this->destination->element('cbc:Note', $this->source->queryValue('./ram:Description', $peymentTermsNode));
+                $this->destination->element('cbc:Note', $peymentTermsDescriptionNode->nodeValue);
                 $this->destination->endElement();
             }
         );