Added Region caching #306
Open
Added Region caching #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
My team and I have been testing the shc connector with high and very high throughput and we realized that its performance dropped significantly around 400 k reads per second and, prior to these changes, we could never go above 500 k reads per second in a stable manner.
We managed to pinpoint and patch the problem. It was related to repeated region queries that saturated the cluster.
We have exposed our changes via parameters, which are disabled by default.
How was this patch tested?
This patch was tested manually. It has also been used extensively in our tests in the CERN's NxCals project for the past 3 weeks. We have deemed it stable and efficient enough to move it to our production environment.