README improvements & fixes #283
Conversation
- Fix jar name to be that of the uber jar - Document how to obtain `atlas-application.properties` - Add instructions for rest client - Clarify the difference in conf between spark deploy modes
| To use it, you will need to make this jar accessible in Spark Driver, also configure | ||
| The connector itself is configured with `atlas-application.properties`. | ||
|
|
||
| To get started, you can copy the `atlas-application.properties` from your Atlas server. |
There was a problem hiding this comment.
I don't know though – is this the recommended way?
| If your Atlas server is not on the same host as where your spark job is run: | ||
| - Replace `atlas.rest.address=http://localhost:21000` with `http://your-atlas-host:21000` | ||
|
|
||
| For production use, consider using `atlas.client.type=kafka` instead. |
There was a problem hiding this comment.
For me kafka didn't work out of box. Maybe I would've had to modify some other properties to set the host names right. Any way, rest should work in all configurations and can be handy when people want to quickly try out this connector.
|
|
||
| ```shell | ||
| bin/spark-shell --jars spark-atlas-connector_2.11-0.1.0-SNAPSHOT.jar \ | ||
| bin/spark-shell --jars spark-atlas-connector-assembly-0.1.0-SNAPSHOT.jar \ |
There was a problem hiding this comment.
Here fixing to use the name of the uberjar. Isn't it generally the jar to be used?
| @@ -25,7 +25,11 @@ To build this project, please execute: | |||
| mvn package -DskipTests | |||
| ``` | |||
|
|
|||
| `mvn package` will assemble all the required dependencies and package into an uber jar. | |||
| `mvn package` will assemble all the required dependencies and package into an uber jar: | |||
There was a problem hiding this comment.
Is this connector supposed to be always built from source, or are ready-made uber jar downloads available somewhere?
|
One more thing: the README doesn't mention any place for discussing SAC, asking questions etc. Is there some mailing list, gitter room or such? Or can github issues be used? |
|
@HeartSaVioR would you have any comments, please? This repo doesn't seem too active though, is this still maintained? |
|
Reiterating @juhoautio comment. Repo does not seem very active. Is this maintained any longer? |
|
I don't think this project is supported any more (#304). It would have been nice if Cloudera had announced that instead of just walking away silently. |
What changes were proposed in this pull request?
atlas-application.propertiesHow was this patch tested?
Manual tests against Atlas 1.0.0 with SAC uber jar built from current master.
Tested both cases:
--deploy-mode cluster+--files s3://my-bucket/atlas-application.properties