Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement quote function in publication contract #28

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

EjembiEmmanuel
Copy link
Contributor

No description provided.

@codeWhizperer
Copy link
Collaborator

@EjembiEmmanuel Kindly add the test cases for this function

@EjembiEmmanuel
Copy link
Contributor Author

@codeWhizperer working on it

@EjembiEmmanuel EjembiEmmanuel marked this pull request as ready for review June 12, 2024 22:54
@EjembiEmmanuel
Copy link
Contributor Author

@codeWhizperer I've added tests

@codeWhizperer
Copy link
Collaborator

@EjembiEmmanuel well-done ser. Kindly emit an event for the quote implementation; you can reference mirror as a guide

@EjembiEmmanuel
Copy link
Contributor Author

Okay

@codeWhizperer
Copy link
Collaborator

Okay

@EjembiEmmanuel And also, extend the test cases. Test for multiple users quoting a post and also for the root_profile_address and pointed_profile_address. once that's done, PR should be good!

@EjembiEmmanuel
Copy link
Contributor Author

Alright, got it!

test multiple usesrs quoting a post
test `root_profile_address`
test `pointed_profile_address`
@codeWhizperer codeWhizperer merged commit 2604a06 into horuslabsio:main Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants