Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Text number formatter for 2 decimal formatting. #81

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

hossain-khan
Copy link
Owner

Added tests as well.

The unit mess is getting out of hands - #60

This pull request introduces a new utility function formatUnit for formatting numerical values with their respective units, and refactors existing code to use this new function. Additionally, it includes tests for the new utility function to ensure its correctness.

Refactoring and Utility Function Addition:

Testing:

Minor Changes:

Added tests as well.

The unit mess is getting out of hands - #60
@hossain-khan hossain-khan self-assigned this Jan 8, 2025
@Copilot Copilot bot review requested due to automatic review settings January 8, 2025 21:14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • app/src/main/java/dev/hossain/weatheralert/notification/Notification.kt: Language not supported
  • app/src/main/java/dev/hossain/weatheralert/ui/alertslist/CurrentAlertScreen.kt: Language not supported
  • app/src/main/java/dev/hossain/weatheralert/util/TextFormatter.kt: Language not supported
  • app/src/test/java/dev/hossain/weatheralert/util/TextFormatterTest.kt: Language not supported
@hossain-khan hossain-khan enabled auto-merge January 8, 2025 21:14
@hossain-khan hossain-khan disabled auto-merge January 8, 2025 21:15
@hossain-khan hossain-khan enabled auto-merge January 8, 2025 21:17
@hossain-khan hossain-khan merged commit c88ee95 into main Jan 8, 2025
3 checks passed
@hossain-khan hossain-khan deleted the add-number-formatter branch January 8, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant