fix singer parsing for columns with dtype object #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsyyid
reviewed
Sep 16, 2024
gluestick/etl_utils.py
Outdated
| @@ -519,7 +519,9 @@ def get(self, stream, default=None, catalog_types=False, **kwargs): | |||
| if catalog and catalog_types: | |||
| types_params = self.get_types_from_catalog(catalog, stream) | |||
| kwargs.update(types_params) | |||
| return pd.read_csv(filepath, **kwargs) | |||
| df = pd.read_csv(filepath, **kwargs) | |||
| df = parse_object_cols(df) | |||
There was a problem hiding this comment.
Let's flag this logic (add a param like parse_objects=False)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The get function assigns dtype "object" to all columns that are of type array or object in the catalog without parsing the data, which creates an stringified invalid json.
Steps to reproduce:
It happens for any css file with columns that have arrays or objects data inside.
Fix:
parse all the columns with dtype object when reading the df.