Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump snapshotting coerce_types logic to handle NAN values for integers #41

Merged
merged 2 commits into from
Sep 30, 2024
Merged

bump snapshotting coerce_types logic to handle NAN values for integers #41

merged 2 commits into from
Sep 30, 2024

Conversation

keyn4
Copy link
Contributor

@keyn4 keyn4 commented Sep 30, 2024

Problem:

  • type coercion during snapshotting fails for int types if there are NAN values

Solution

  • Use Int64 for all integer dtypes, only Int64 supports NAN values when casting a column to integers

@hsyyid hsyyid merged commit a6389d7 into master Sep 30, 2024
0 of 4 checks passed
@hsyyid hsyyid deleted the HGI-6549 branch September 30, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsyyid hsyyid hsyyid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyn4 @hsyyid