Add duplicity handle for subscription stream #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyn4
reviewed
Nov 11, 2024
tap_chargebee/streams/base.py
Outdated
| if self.ENTITY in ['transaction', 'subscription']: | ||
| # store ids to clean dupplicates, keep only the last appearance of a record id | ||
| new_records = [] | ||
| for record in reversed(to_write): |
There was a problem hiding this comment.
if the goal is to keep the latest updated record, I think this will only work if the duplicates are in the same response page, if that's not that relevant please ignore.
There was a problem hiding this comment.
Pushed a fix for that. Thank you 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.