Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type dates as DateTimeType #70

Open
wants to merge 1 commit into
base: HGI-5253
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tap_hubspot_beta/client_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,11 @@ def validate_response(self, response: requests.Response) -> None:
@staticmethod
def extract_type(field):
field_type = field.get("type")
if field_type in ["string", "enumeration", "phone_number", "date", "json", "object_coordinates"]:
if field_type in ["string", "enumeration", "phone_number", "json", "object_coordinates"]:
return th.StringType
if field_type == "number":
return th.StringType
if field_type == "datetime":
if field_type in ["datetime", "date"]:
return th.DateTimeType
if field_type == "bool":
return th.BooleanType
Expand Down