add support to send attachments #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsyyid
reviewed
Dec 3, 2024
target_salesforce_v3/sinks.py
Outdated
| @@ -1047,3 +1060,31 @@ def upsert_record(self, record, context): | |||
| self.logger.exception(f"Error encountered while creating {object_type}") | |||
| raise e | |||
|
|
|||
|
|
|||
| def link_attachment_to_object(self, file_id, linked_object_id): | |||
| if self.name == "ContentVersion" and not linked_object_id: | |||
There was a problem hiding this comment.
What happens if this is called when linked_object_id is None and self.name != "ContentVersion"?
hsyyid
reviewed
Dec 4, 2024
target_salesforce_v3/sinks.py
Outdated
| @@ -1047,3 +1060,31 @@ def upsert_record(self, record, context): | |||
| self.logger.exception(f"Error encountered while creating {object_type}") | |||
| raise e | |||
|
|
|||
|
|
|||
| def link_attachment_to_object(self, file_id, linked_object_id): | |||
| if self.name == "ContentVersion": | |||
There was a problem hiding this comment.
It's generally cleaner to do:
if self.name != "ContentVersion":
return
# rest of code here ...
hsyyid
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.