Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Fix mapathon detail endpoint in dev setup #329

Conversation

NicolasGrosjean
Copy link
Contributor

@NicolasGrosjean NicolasGrosjean commented Sep 18, 2022

Issues solved by this PR:

  • psycopg2.errors.UndefinedFunction: function public.editors_per_user(bigint, unknown, unknown) does not exist
  • configparser.NoSectionError: No section: 'TM'
  • add fixtures

Add the database with its tables but it it is empty.
- Use TM test fixture
- Set database name to lower case
@NicolasGrosjean NicolasGrosjean marked this pull request as ready for review September 18, 2022 11:11
Copy link
Member

@kshitijrajsharma kshitijrajsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy with this PR , This fix will allow user to do TM related Code setup on galaxy API , I haven't focused on TM as it is optional , However I won't recommend using dblink to talk to database Since we are already connected to TM from galaxy API I will recommend to link the result from API End directly , so that further development on the function will be easy , cc : @d-rita Tagging you here , If you have any recommendation why you went with dblink for the this editors_per_user as a database function itself ! I will approve these changes for now ! Meanwhile we can improve functionality of detailed endpoint later on !

@d-rita
Copy link
Contributor

d-rita commented Sep 19, 2022

@kshitijrajsharma the editors_per_user function is the remaining dblink function from the earlier TM stats implementation by @omranlm. But since we can now set up and talk to the TM database directly via the API, I agree it is better to remove all dblink functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][DEV] Running /mapathon/detail
3 participants