Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript-vite: fix(frontend): i18n, projects list, icon, tasks #6696

Merged
merged 7 commits into from
Jan 18, 2025
Merged

typescript-vite: fix(frontend): i18n, projects list, icon, tasks #6696

merged 7 commits into from
Jan 18, 2025
+7 −7

Conversation

JoltCode
Copy link
Collaborator

@JoltCode JoltCode commented Jan 18, 2025 •
edited
Loading

Fixes:

  • i18n not working at all, was importing just the module, not the contents
  • persist project data between renders on project page - broken by tanstack query bump
  • invalid svg property on grid icon - renamed property to camel case
  • missing ternary when accessing authDetails in taskSelection causing runtime error/crash - added ternary

@JoltCode JoltCode changed the title fix(frontend): i18n breaking typescript-vite: fix(frontend): i18n breaking Jan 18, 2025
@JoltCode JoltCode requested a review from spwoodcock January 18, 2025 20:13
@JoltCode JoltCode changed the title typescript-vite: fix(frontend): i18n breaking typescript-vite: fix(frontend): i18n, projects list, icon, tasks Jan 18, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@spwoodcock spwoodcock merged commit b43b3b5 into hotosm:typescript-vite Jan 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoltCode @spwoodcock